Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump to fix dependencies #32

Closed
wants to merge 1 commit into from
Closed

Version bump to fix dependencies #32

wants to merge 1 commit into from

Conversation

scottspork
Copy link

No description provided.

@vanm
Copy link

vanm commented Jul 17, 2014

@stelcheck @ronkorving any chance you could merge this version bump? The old dependencies result in API breaks. One example is the sanitize method was removed from validator, resulting in pivotal.addStoryComment being broken.

@stelcheck
Copy link
Member

Dear god, sorry for being late on this one. If you can confirm this works, I will gladly merge. Might not have a lot of time for testing myself, unfortunately...

@vanm
Copy link

vanm commented Jul 20, 2014

@stelcheck make test passes when I run it against a pivotal project. There are some JSHint errors that I fixed in a separate branch. My smoke tests with core pivotal APIs worked as expected.

@stelcheck
Copy link
Member

Could you submit a PR with the JSHint fixes? I'll make sure to merge ASAP

@vanm
Copy link

vanm commented Jul 20, 2014

Sure thing - submitted. I suggest moving to JSHint in a follow-up (the project is using JSLint). Some of the lint warnings are not actionable or relevant (like var in a for statement), so I ignored them for now.

@vanm
Copy link

vanm commented Jul 29, 2014

@stelcheck Any blockers to merging this?

@stelcheck
Copy link
Member

Me obviously :/ Sorry, I'll try to get to test it within the next 24 hours

@vanm
Copy link

vanm commented Oct 18, 2014

@stelcheck This should be good to go - if we could include #33 in 0.2.1 that would improve some of the documentation.

@stelcheck
Copy link
Member

This PR only has the version bump left in terms of code change. I'll make the bump as soon as we get some of the remaining issues out of the way (see #35)

@stelcheck stelcheck closed this Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants